Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup to rest api page #763

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kprosise
Copy link
Contributor

Focus was on changing the api link so that customers not logged in would see a notice of such rather than a page error. An admonition to this effect was added.
All links to the api were changed as otherwise they would need individual references.

Other minor clean done.

No related ticket, quick fix.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Follows up to discussion of issue.

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

@kprosise kprosise requested review from vanmaegima, caiotpereira and a team October 25, 2024 08:38
@doanac
Copy link
Member

doanac commented Oct 25, 2024

Focus was on changing the api link so that customers not logged in would see
a notice of such rather than a page error. An admonition to this effect was
added.
All links to the api were changed as otherwise they would need individual
references.

Other minor clean done.

No related ticket, quick fix.

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise force-pushed the rest-api-login-note branch from 1e6b5ce to 534df18 Compare October 30, 2024 08:12
@doanac
Copy link
Member

doanac commented Oct 30, 2024

@kprosise kprosise merged commit c791438 into foundriesio:main Oct 30, 2024
2 of 3 checks passed
@kprosise kprosise deleted the rest-api-login-note branch October 30, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants