Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken ref to board machine names page #776

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

kprosise
Copy link
Contributor

Added space, link is now in the generated HTML as intended.

QA: checked rendered output and link. Ran linkcheck. No reason to run linter.

This commit addresses FS-2843, re: fix see:ref:ref-linux-supported

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Added space, link is now in the generated HTML as intended.

QA: checked rendered output and link. Ran linkcheck. No reason to run
linter.

This commit addresses FS-2843, re: fix see:ref:ref-linux-supported

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise requested review from Tim-Anderson, vanmaegima and a team November 27, 2024 16:24
@doanac
Copy link
Member

doanac commented Nov 27, 2024

Copy link
Contributor

@Tim-Anderson Tim-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanmaegima
Copy link
Member

@kprosise this should be good to merge so I can close the customer ticket.

@kprosise kprosise merged commit 71ba8e1 into foundriesio:main Dec 4, 2024
3 checks passed
@kprosise kprosise deleted the fix-broken-refs branch December 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants