Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast proof slot should be padded to 32 bytes #1052

Closed
wants to merge 1 commit into from
Closed

fix: cast proof slot should be padded to 32 bytes #1052

wants to merge 1 commit into from

Conversation

excaliborr
Copy link

@excaliborr excaliborr commented Nov 22, 2023 •
edited
Loading

  • cast proof seems to be expecting the bytes32(uint256(0)) and not just the uint256(0) to get a specific storage slot proof

mattsse
mattsse approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@mattsse
Copy link
Member

mattsse commented Nov 22, 2023

actually, this isn't necessary foundry-rs/foundry#6403

@DaniPopes DaniPopes mentioned this pull request Nov 22, 2023
Merged
@excaliborr excaliborr closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@excaliborr @mattsse