Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Prague evm version #166

Merged
merged 6 commits into from
Jul 26, 2024
Merged

feat: add Prague evm version #166

merged 6 commits into from
Jul 26, 2024

Conversation

rakita
Copy link
Contributor

@rakita rakita commented Jul 10, 2024

Adds Prague spec.

TODO: PragueEOF support is needed.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add this to the enum because solc already has support for this

https://github.com/ethereum/solidity/blob/5e9d38e9dc23d124b87bc3aa85714fd4db7c8820/liblangutil/EVMVersion.h#L63

but we can't add it to normalize_version_solc yet because we don't know the version yet and 0.8.26 is incorrect I believe because that's the latest release:

https://github.com/ethereum/solidity/releases/tag/v0.8.26

@fgimenez
Copy link
Contributor

but we can't add it to normalize_version_solc yet because we don't know the version yet and 0.8.26 is incorrect I believe because that's the latest release:

good catch, I see in solidity's repo that the prague EVM version has been already introduced ethereum/solidity#15152 not sure if this means it will be part of the next release?

@klkvr klkvr force-pushed the rakita/prague_spec branch from 69cc744 to d01269f Compare July 26, 2024 10:22
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klkvr klkvr merged commit 6498e98 into main Jul 26, 2024
15 checks passed
@DaniPopes DaniPopes deleted the rakita/prague_spec branch July 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants