Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EvmVersion from_str #235

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: EvmVersion from_str #235

merged 1 commit into from
Dec 20, 2024

Conversation

yash-atreya
Copy link
Member

Currently, EvmVersion won't get deserialized for spuriousdragon and tangerinewhistle.

This can be reproduced using:

cast run 0x6b5ca68eb4c4b38690ec12ba9f85409b618759646e50ab53b28f9d67f74978fc --rpc-url=https://rpc.ankr.com/eth --evm-version spuriousDragon
Error: failed to extract foundry config:
foundry config error: Unknown evm version: spuriousdragon for key "default.evm_version" in RunArgs for setting `evm_version`

Solution:

Handle camel case and lowercase

@mattsse mattsse merged commit 4a49c1b into main Dec 20, 2024
15 checks passed
@mattsse mattsse deleted the yash/fix-evm-from-str branch December 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants