Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Box<dyn> in sparse functions #39

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat: use Box<dyn> in sparse functions #39

merged 1 commit into from
Jan 4, 2024

Conversation

DaniPopes
Copy link
Member

To avoid boxing twice in case that an argument is already a box.

@DaniPopes DaniPopes requested a review from Evalir as a code owner January 4, 2024 02:10
Evalir
Evalir approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@DaniPopes DaniPopes merged commit 38afb36 into main Jan 4, 2024
20 checks passed
@DaniPopes DaniPopes deleted the dani/sparse branch January 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @Evalir