Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to custom maxPriorityFeePerGas on Solidity-Scripting #3642

Closed
rkdud007 opened this issue Nov 8, 2022 · 3 comments
Closed

Able to custom maxPriorityFeePerGas on Solidity-Scripting #3642

rkdud007 opened this issue Nov 8, 2022 · 3 comments
Labels
C-forge Command: forge Cmd-forge-script Command: forge script T-feature Type: feature

Comments

@rkdud007
Copy link

rkdud007 commented Nov 8, 2022

Component

Forge

Describe the feature you would like

I cannot find how to use forge-script options and Solidity Scripting to handle maxPriorityFeePerGas or maxFeePerGas (eip-1559).

I made a similar issue & pr on hardhat.

for better gas optimization for dev, I think forge-scripting with eip-1559 adopt is quite important feature.

Additional context

I attached some links above.

@rkdud007 rkdud007 added the T-feature Type: feature label Nov 8, 2022
@rkrasiuk rkrasiuk added C-forge Command: forge Cmd-forge-script Command: forge script labels Nov 10, 2022
@Sabnock01
Copy link
Contributor

@Evalir is this resolved by #5585 ?

@mds1
Copy link
Collaborator

mds1 commented Aug 30, 2023

It seems now we have a --priority-gas-price flag which handles the maxPriorityFeePerGas field, and a --with-gas-price flag handles the maxFeePerGas field for 1559 transactions, so seems this can be closed. Thanks!

@mds1 mds1 closed this as completed Aug 30, 2023
@Sabnock01
Copy link
Contributor

It seems now we have a --priority-gas-price flag which handles the maxPriorityFeePerGas field, and a --with-gas-price flag handles the maxFeePerGas field for 1559 transactions, so seems this can be closed. Thanks!

We should probably just implement TransactionOpts for forge script instead of reinventing the wheel with these flags. That can maybe be its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-script Command: forge script T-feature Type: feature
Projects
None yet
Development

No branches or pull requests

4 participants