Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(script): tracking issue for script improvements #4444

Open
mds1 opened this issue Feb 27, 2023 · 4 comments
Open

meta(script): tracking issue for script improvements #4444

mds1 opened this issue Feb 27, 2023 · 4 comments
Labels
C-forge Command: forge Cmd-forge-script Command: forge script T-meta Type: meta

Comments

@mds1
Copy link
Collaborator

mds1 commented Feb 27, 2023

roughly prioritized/sorted, still a work in progress

High Priority

These are high priority because they block deployment, and user's need to find workarounds or user other tools as a result

Library Issues

Ledger Issues

Other

These are not yet sorted

@mds1 mds1 added C-forge Command: forge T-meta Type: meta Cmd-forge-script Command: forge script labels Feb 27, 2023
@odyslam
Copy link
Contributor

odyslam commented Feb 27, 2023

Based on our experience in making multiple deployments in December 2022, a big takeaway was that the transaction lifecycle management needed rework.

Due to unreliable RPC providers and network issues, the foundry script should be more robust in handling these issues and issuing the proper transactions in the appropriate order.

Relevant issues are being discussed afaik in the ethers-rs telegram, so I understand that the required work is part foundry script, part ethers-rs.

The TL;DR is that the forge script should be more robust and recover from more failures without the user resorting to multiple --resume executions.

@sambacha
Copy link
Contributor

sambacha commented May 6, 2023

Based on our experience in making multiple deployments in December 2022, a big takeaway was that the transaction lifecycle management needed rework.

Due to unreliable RPC providers and network issues, the foundry script should be more robust in handling these issues and issuing the proper transactions in the appropriate order.

Relevant issues are being discussed afaik in the ethers-rs telegram, so I understand that the required work is part foundry script, part ethers-rs.

The TL;DR is that the forge script should be more robust and recover from more failures without the user resorting to multiple --resume executions.

Why not just let users submit bundles instead of individual transactions? That removes a lot of issues.

No need to recover if atomic.

@mds1
Copy link
Collaborator Author

mds1 commented May 6, 2023

I agree that would be a nice feature, but it only helps on mainnet when the total bundle uses <30M gas, so it doesn’t solve the problem for all users and all chains

@sambacha
Copy link
Contributor

I agree that would be a nice feature, but it only helps on mainnet when the total bundle uses <30M gas, so it doesn’t solve the problem for all users and all chains

Ethereum mainnet is the relevant chain. Supporting submission via bundles can be adopted downstream by other chains.

Transaction submission bundling isn't about gas usage per se, it's about atomic deployment.

The case about other users and other chains is irrelevant, as it does not worsen their situation.

@zerosnacks zerosnacks modified the milestone: v1.0.0 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-script Command: forge script T-meta Type: meta
Projects
Status: Todo
Development

No branches or pull requests

4 participants