Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In broadcast log, include arg names and use standard syntax #3887

Open
adhusson opened this issue Dec 13, 2022 · 0 comments
Open

In broadcast log, include arg names and use standard syntax #3887

adhusson opened this issue Dec 13, 2022 · 0 comments
Labels
C-forge Command: forge Cmd-forge-script Command: forge script good first issue Good for newcomers P-low Priority: low T-feature Type: feature

Comments

@adhusson
Copy link
Contributor

Component

Forge

Describe the feature you would like

Description

For now the function field of a broadcast log's transaction looks like:

"function": "functionName(type1,type2):(returnType)",

More useful and more standard (ie parseable by ethers.js' human-readable ABI parser) would be :

"function": "functionName(type1,type2 name2) returns (returnType)",

Differences:

  • The name of the argument is there when available (useful when the broadcat log is an input to a UI) (keeps more info)
  • : becomes returns (helps with parsing)

Alternative

Stay in full json and have something like

{
  "name":"functionName",
  "payable":false,
  "inputs":[{"type":"type1"},{"type":"type2", "name":"name2"}],
  "outputs":[{"type":"returnType"}]
}

Additional context

No response

@adhusson adhusson added the T-feature Type: feature label Dec 13, 2022
@rkrasiuk rkrasiuk added C-forge Command: forge Cmd-forge-script Command: forge script labels Dec 22, 2022
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@grandizzy grandizzy added good first issue Good for newcomers P-low Priority: low labels Oct 17, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Nov 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-script Command: forge script good first issue Good for newcomers P-low Priority: low T-feature Type: feature
Projects
Status: Todo
Development

No branches or pull requests

4 participants