Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge verify-contract): support fully verifying a partially-verified contract #6424

Closed
tsite opened this issue Nov 25, 2023 · 1 comment
Closed

feat(forge verify-contract): support fully verifying a partially-verified contract #6424

tsite opened this issue Nov 25, 2023 · 1 comment
Labels
T-feature Type: feature

Comments

@tsite
Copy link
Contributor

tsite commented Nov 25, 2023

Component

Forge

Describe the feature you would like

forge verify-contract does not attempt to re-verify an already-verified contract as this is an expensive operation. However there are some cases in which this behavior is desired e.g. to re-verify a partially-verified contract with source code that matches the metadata hash. I suggest adding a flag --ignore-already-verified to the verifier command-line arguments to skip the contract already verified check.

Additional context

No response
@tsite tsite added the T-feature Type: feature label Nov 25, 2023
@gakonst gakonst added this to Foundry Nov 25, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 25, 2023
@tsite tsite mentioned this issue Nov 25, 2023
Closed
@mattsse
Copy link
Member

mattsse commented Dec 5, 2023

closed by #6461

@mattsse mattsse closed this as completed Dec 5, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(forge): add --ignore-already-verified flag to verify-contract tsite/foundry
2 participants
@tsite @mattsse