feat(forge): add --ignore-already-verified flag to verify-contract #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set this flag to true when deploying new contracts to ensure that they are fully verified instead of partially verified. Set this flag to false by default when running forge verify-contract manually.
|
no worries - still think it would be nice to default to verifying all contracts during deployment (even if the bytecode matches another contract that is partially verified) so that they are fully instead of partially verified. what do you think @mattsse? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set this flag to true when deploying new contracts to ensure that they are fully verified instead of partially verified.
Set this flag to false by default when running forge verify-contract manually.
CLOSES #6424
Motivation
forge verify-contractdoes not attempt to re-verify an already-verified contract as this is an expensive operation. However there are some cases in which this behavior is desired e.g. to re-verify a partially-verified contract with source code that matches the metadata hash.Solution
I suggest adding a flag
--ignore-already-verifiedto the verifier command-line arguments to skip the contract already verified check.