Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace anvil OP types with op-alloy #8575

Closed
mattsse opened this issue Jul 31, 2024 · 4 comments · Fixed by #9047
Closed

replace anvil OP types with op-alloy #8575

mattsse opened this issue Jul 31, 2024 · 4 comments · Fixed by #9047
Assignees
@yash-atreya @programskillforverification
Labels
A-internals Area: internals C-anvil Command: anvil good first issue Good for newcomers T-feature Type: feature
Milestone
v1.0.0

Comments

@mattsse
Copy link
Member

mattsse commented Jul 31, 2024

Component

Anvil

Describe the feature you would like

this anvil type

foundry/crates/anvil/core/src/eth/transaction/optimism.rs

Line 13 in c998542

pub struct DepositTransactionRequest {

should be equivalent to

https://github.com/alloy-rs/op-alloy/blob/2ecb2e50ec705df6615596b6c5bde879c6f7dee1/crates/consensus/src/transaction/deposit.rs#L12

and could be replaced

Additional context

No response
@mattsse mattsse added T-feature Type: feature good first issue Good for newcomers labels Jul 31, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 31, 2024
@zerosnacks zerosnacks added C-anvil Command: anvil A-internals Area: internals labels Jul 31, 2024
@programskillforverification
Copy link
Contributor

I would like to solve this. Please assign it to me.

@programskillforverification
Copy link
Contributor

@mattsse is necessary to rename the file?

@mattsse
Copy link
Member Author

mattsse commented Aug 2, 2024

not necessary

Closed
@zerosnacks zerosnacks mentioned this issue Sep 24, 2024
Closed
@yash-atreya yash-atreya linked a pull request Oct 9, 2024 that will close this issue
chore(anvil): use op-alloy types #9047
Merged
@yash-atreya
Copy link
Member

Closed by #9047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-atreya yash-atreya

@programskillforverification programskillforverification

Labels
A-internals Area: internals C-anvil Command: anvil good first issue Good for newcomers T-feature Type: feature
Projects
None yet
Milestone
v1.0.0
4 participants
@mattsse @yash-atreya @programskillforverification @zerosnacks