Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace anvil OP types with op-alloy #8595

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

replace anvil OP types with op-alloy #8595

wants to merge 7 commits into from

Conversation

programskillforverification
Copy link
Contributor

Motivation

close #8575

Solution

@programskillforverification programskillforverification marked this pull request as ready for review August 3, 2024 08:15
@mattsse mattsse mentioned this pull request Aug 24, 2024
Open
mattsse
mattsse requested changes Aug 24, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to replace the anvil deposit type entirely with the op-alloy I think?

@programskillforverification
Copy link
Contributor Author

we should be able to replace the anvil deposit type entirely with the op-alloy I think?

All struct fields name is the same as op-alloy?

@yash-atreya yash-atreya mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr left review comments

@mattsse mattsse mattsse requested changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace anvil OP types with op-alloy
3 participants
@programskillforverification @mattsse @klkvr