Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge build): --watch flag should watch foundry.toml config changes #9099

Closed
radeksvarz opened this issue Oct 12, 2024 · 3 comments · Fixed by #9148
Closed

feat(forge build): --watch flag should watch foundry.toml config changes #9099

radeksvarz opened this issue Oct 12, 2024 · 3 comments · Fixed by #9148
Labels
A-config Area: config C-forge Command: forge Cmd-forge-build Command: forge build first issue A good way to start contributing T-feature Type: feature

Comments

@radeksvarz
Copy link

Component

Forge

Describe the feature you would like

currently build -w watches sol files, it would be helpful to watch also config files

Additional context

No response
@radeksvarz radeksvarz added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Oct 12, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 12, 2024
@zerosnacks zerosnacks changed the title build -w should watch foundry.toml config changes feat(forge build): --watch flag should watch foundry.toml config changes Oct 14, 2024
@zerosnacks zerosnacks added Cmd-forge-build Command: forge build A-config Area: config C-forge Command: forge and removed T-needs-triage Type: this issue needs to be labelled labels Oct 14, 2024
@DaniPopes DaniPopes added the first issue A good way to start contributing label Oct 16, 2024
@Ifechukwudaniel
Copy link

Should there be an argument for this feature

@zerosnacks
Copy link
Member

@Ifechukwudaniel no new argument, this should be added to forge build --watch

@leovct
Copy link
Contributor

leovct commented Oct 19, 2024

I'd like to tackle this issue :)

@leovct leovct mentioned this issue Oct 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-config Area: config C-forge Command: forge Cmd-forge-build Command: forge build first issue A good way to start contributing T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(forge build): --watch flag now watches foundry.toml config… leovct/foundry
5 participants
@radeksvarz @leovct @Ifechukwudaniel @DaniPopes @zerosnacks