Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge build): --watch flag now watches foundry.toml config… #9148

Conversation

leovct
Copy link
Contributor

@leovct leovct commented Oct 19, 2024

… changes

Motivation

Closes #9099

Solution

Monitor foundry.toml on top of Solidity file changes when using forge build --watch.

Tested on a local project. When updating foundry.toml, forge build --watch will try to re-build the files as expected.

@leovct leovct marked this pull request as ready for review October 19, 2024 23:46
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, makes sense if you change the solc version for example. thank you!

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leovct! LGTM

Tested it on an example project, works well

@zerosnacks zerosnacks merged commit 52b3da2 into foundry-rs:master Oct 21, 2024
21 checks passed
@leovct leovct deleted the feat/forge-build-watch-flag-watches-foundry-toml-config-changes branch October 21, 2024 08:19
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
foundry-rs#9148)

feat(`forge build`): `--watch` flag now watches `foundry.toml` config changes
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-feature Type: feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat(forge build): --watch flag should watch foundry.toml config changes
3 participants