feat(forge): verify contracts created inside a call #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
Cmd-forge-verify
onbjerg
reviewed
Aug 19, 2022
| env: | ||
| CARGO_TERM_COLOR: always | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Would prefer that this is in the main test workflow since it compiles once or twice and then reuses the compiled test binary
gakonst
approved these changes
Aug 19, 2022
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
* verify contracts created inside a call * flat map * one less arg try_verify_contract * change name to get_verify_args * style * use AdditionalContract * add CallKind::Create2 * add additional info to trace.address doc * add commit to broadcast log * remove expect * specify how many contracts are being verified * successful verification message * make sure verifiers have library info * add complex deployment and verification test * add ci job for live tests on master * exclude live tests from PRs * fix text * change job name
|
I'm on the most recent version of foundry and am having trouble automatically verifying contracts deployed within other contracts. Currently, it will only automatically verify the top level contracts being deployed. Is there some recommended solution for this? 🤔 💭 |
|
Hi @alphak3y, would you mind opening up a new issue with this, preferably with a minimal reproduction / additional details? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Identifies and verifies contracts created during a
callordeploy.ref #2518 (comment)
Solution
Since we recently enabled the traces for all scripts, independently of verbosity, we can get all the contracts through
CallKind::CreateandCallKind::Create2traces.Also:
${{ secrets.ETHERSCAN_API_KEY }}${{ secrets.TEST_PRIVATE_KEY }}. It deploys and verifies a script which uses predeployed libraries and contracts create inside contracts.