Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geiger): paths ignore option #4235

Merged
merged 2 commits into from
Jan 31, 2023
Merged

feat(geiger): paths ignore option #4235

merged 2 commits into from
Jan 31, 2023

Conversation

rkrasiuk
Copy link
Collaborator

closes #3952

Add --ignore option to forge geiger

@rkrasiuk rkrasiuk added T-feature Type: feature C-forge Command: forge Cmd-forge-geiger Command: forge geiger labels Jan 31, 2023
@rkrasiuk rkrasiuk requested a review from mattsse January 31, 2023 13:59
mattsse
mattsse approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, smol lint issue

@rkrasiuk
Copy link
Collaborator Author

unrelated test cancellation

@rkrasiuk rkrasiuk merged commit 8b3d6ab into master Jan 31, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/feat-geiger-ignore-option branch January 31, 2023 15:55
@DaniPopes DaniPopes mentioned this pull request Feb 11, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
C-forge Command: forge Cmd-forge-geiger Command: forge geiger T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge geiger should ignore /lib/forge-std
2 participants
@rkrasiuk @mattsse