Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: some alloy cleanup #5975

Merged
merged 4 commits into from
Oct 2, 2023
Merged

chore: some alloy cleanup #5975

merged 4 commits into from
Oct 2, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Oct 2, 2023 •
edited
Loading

Motivation

  • Use Display for alloy address
  • Use Address:: methods instead of ethers utils
  • hex::encode clean up
  • make nonces u64 since we would panic anyway if above

Solution

mattsse
mattsse approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

smol compile error, redundant into maps

@mattsse mattsse merged commit dd89d64 into foundry-rs:master Oct 2, 2023
17 checks passed
@DaniPopes DaniPopes deleted the alloy-cleanup branch October 2, 2023 23:31
@DaniPopes DaniPopes mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse