Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix forge create argument parsing (#473) #622

Merged
merged 1 commit into from
Jan 29, 2022
Merged

chore: fix forge create argument parsing (#473) #622

merged 1 commit into from
Jan 29, 2022

Conversation

calldata
Copy link
Contributor

Motivation

Solution

mattsse
mattsse approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm
this allows both variants:

--constructor-args a b c

and

--constructor-args a --constructor-args b --constructor-args c

@onbjerg onbjerg added the T-bug Type: bug label Jan 29, 2022
gakonst
gakonst approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice one, yes @mattsse

@gakonst gakonst merged commit 0773fb4 into foundry-rs:master Jan 29, 2022
@Leechael Leechael mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calldata @gakonst @mattsse @onbjerg