Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): fail fast after processing traces #6628

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix(forge): fail fast after processing traces #6628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/forge/bin/cmd/test/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,11 +407,6 @@ impl TestArgs {
for (name, result) in &mut tests {
short_test_result(name, result);

// If the test failed, we want to stop processing the rest of the tests
if self.fail_fast && result.status == TestStatus::Failure {
break 'outer
}

// We only display logs at level 2 and above
if verbosity >= 2 {
// We only decode logs from Hardhat and DS-style console events
Expand Down Expand Up @@ -482,6 +477,11 @@ impl TestArgs {
if self.gas_report {
gas_report.analyze(&result.traces);
}

// If the test failed, we want to stop processing the rest of the tests
if self.fail_fast && result.status == TestStatus::Failure {
break 'outer
}
}
let block_outcome = TestOutcome::new(
[(contract_name.clone(), suite_result)].into(),
Expand Down