Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inline test config: enable ast for test #7314

Closed
wants to merge 1 commit into from

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #7310

Solution

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this

pending @DaniPopes

@grandizzy
Copy link
Collaborator Author

pending some test fixes

@DaniPopes
Copy link
Member

I thought it never worked, we don't have any tests for inline config.
In any case, I don't want to enable this for all tests since this defeats the purpose of #7197. I would much rather refactor inline config parsing to not use Solc AST.

@DaniPopes DaniPopes closed this Mar 5, 2024
@shuhuiluo
Copy link

I thought it never worked, we don't have any tests for inline config. In any case, I don't want to enable this for all tests since this defeats the purpose of #7197. I would much rather refactor inline config parsing to not use Solc AST.

Hope you bring it back soon. The use case for me is to limit the runs for fork fuzzing tests which are rate limited while going crazy on local fuzzing runs.

@grandizzy
Copy link
Collaborator Author

I thought it never worked, we don't have any tests for inline config. In any case, I don't want to enable this for all tests since this defeats the purpose of #7197. I would much rather refactor inline config parsing to not use Solc AST.

There are actually couple of tests but seems they are run with ast on https://github.com/foundry-rs/foundry/blob/master/crates/forge/tests/it/inline.rs

@DaniPopes
Copy link
Member

Hope you bring it back soon. The use case for me is to limit the runs for fork fuzzing tests which are rate limited while going crazy on local fuzzing runs.

Understandable, I will look into this today, thanks for flagging

@grandizzy grandizzy deleted the 7310 branch March 5, 2024 12:24
@DaniPopes
Copy link
Member

Opened #7431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-line test configuration not respected
4 participants