Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports socket address as --rpc-url input #7389

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat: supports socket address as --rpc-url input #7389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667e8d4
feat: supports socket address
kamuik16 Mar 13, 2024
22df660
cargo fmt and clippy
kamuik16 Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions crates/common/src/provider/alloy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ use foundry_common::types::ToAlloy;
use foundry_config::NamedChain;
use reqwest::Url;
use std::{
net::SocketAddr,
path::{Path, PathBuf},
str::FromStr,
time::Duration,
};
use url::ParseError;
Expand Down Expand Up @@ -93,12 +95,16 @@ impl ProviderBuilder {
let url = Url::parse(url_str)
.or_else(|err| match err {
ParseError::RelativeUrlWithoutBase => {
let path = Path::new(url_str);

if let Ok(path) = resolve_path(path) {
Url::parse(&format!("file://{}", path.display()))
if SocketAddr::from_str(url_str).is_ok() {
Url::parse(&format!("http://{}", url_str))
} else {
Err(err)
let path = Path::new(url_str);

if let Ok(path) = resolve_path(path) {
Url::parse(&format!("file://{}", path.display()))
} else {
Err(err)
}
}
}
_ => Err(err),
Expand Down
Loading