feat: library deployments though CREATE2 #7711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/library-create2
branch
from
34e8cb2 to
c33d485
Compare
|
needs foundry-rs/compilers#108 and will be blocked by yansi update |
mattsse
pushed a commit
to foundry-rs/compilers
that referenced
this pull request
Apr 20, 2024
#108) I'm writing tests for foundry-rs/foundry#7711 which are hardcoding CREATE2 library deployment addreses and they are currently failing on Windows probably because \r\n line endings which are causing metadata differences. This PR tries to fix this by replacing such endings with \n
klkvr
changed the title
DaniPopes
reviewed
Apr 22, 2024
klkvr
force-pushed
the
klkvr/library-create2
branch
2 times, most recently
from
9b229cd to
08f3c41
Compare
DaniPopes
approved these changes
Apr 25, 2024
mds1
reviewed
Apr 27, 2024
mattsse
approved these changes
May 13, 2024
klkvr
force-pushed
the
klkvr/library-create2
branch
from
3a0ce36 to
e8cc161
Compare
klkvr
force-pushed
the
klkvr/library-create2
branch
from
e8cc161 to
d9820a1
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4810
ref #7027 (comment)
Solution
This PR introduces a new approach to library linking for scripts. If CREATE2 deployer is present on target chain, ibraries are deployed through it, and only if they have not been deployed before. This makes it possible for users to run scripts without ever thinking about library deployment and need to provide addresses in
foundry.tomlor via--librariesargs.Salt for deployments can be configured through
create2_library_salt.It is not possible to link libraries with cyclic dependencies in such way, so we are still falling back to default linking algo if error occurs.