Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anvil): switch to alloy types #8186

Merged
merged 10 commits into from
Jun 19, 2024
Merged

feat(anvil): switch to alloy types #8186

merged 10 commits into from
Jun 19, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jun 18, 2024 •
edited
Loading

Motivation

Closes #8084

Solution

  • Use Anvil types from Alloy in favor of local types
  • Move rpc-types-* over to use rpc-types metacrate consistently
  • Upstream changes in Alloy now handle deserialization issue in MineOptions correctly

Context

Tagged @moricho as co-author for his prior work here: #8098

zerosnacks and others added 2 commits June 18, 2024 10:45
@zerosnacks @moricho
update to use anvil rpc types
b1bdeca 
Co-authored-by: moricho <ikeda.morito@gmail.com>
@zerosnacks
remove redundant types
2873516
@zerosnacks zerosnacks mentioned this pull request Jun 18, 2024
Closed
3 tasks
@zerosnacks zerosnacks added the T-blocked Type: blocked label Jun 18, 2024
@zerosnacks zerosnacks mentioned this pull request Jun 18, 2024
Merged
3 tasks
@zerosnacks zerosnacks removed the T-blocked Type: blocked label Jun 19, 2024
@zerosnacks
Copy link
Member Author

Test failure appears to be unrelated (cc @grandizzy)

@zerosnacks zerosnacks marked this pull request as ready for review June 19, 2024 08:53
@grandizzy
Copy link
Collaborator

Test failure appears to be unrelated (cc @grandizzy)

yep, going to fix it, the problem is test_invariant runs all test_invariant_* tests but does not respect their seed

@zerosnacks zerosnacks marked this pull request as draft June 19, 2024 09:56
@zerosnacks zerosnacks added the T-blocked Type: blocked label Jun 19, 2024
@zerosnacks zerosnacks removed the T-blocked Type: blocked label Jun 19, 2024
@zerosnacks zerosnacks marked this pull request as ready for review June 19, 2024 11:35
mattsse
mattsse approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse merged commit dee33a0 into master Jun 19, 2024
20 checks passed
@mattsse mattsse deleted the zerosnacks/switch-to-alloy-types-anvil branch June 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Alloy's alloy-rpc-types-anvil types
3 participants
@zerosnacks @grandizzy @mattsse