Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Mandala + Karura + Acala as exceptions for gas calculation during deployment #8625

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Aug 8, 2024

Motivation

add Mandala + Karura + Acala as exceptions for gas calculation during deployment
Resolves: AcalaNetwork/Acala#2769 (reply in thread)

Related: alloy-rs/chains#76

Solution

@zjb0807 zjb0807 marked this pull request as draft August 8, 2024 04:25
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, new chains release is out this can be bumped now

@zjb0807 zjb0807 marked this pull request as ready for review August 8, 2024 11:10
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zerosnacks zerosnacks enabled auto-merge (squash) August 8, 2024 11:38
@zerosnacks zerosnacks merged commit 960878a into foundry-rs:master Aug 8, 2024
21 checks passed
@zjb0807 zjb0807 deleted the support-acala-karura branch August 8, 2024 23:42
benwjhack pushed a commit to CompassLabs/foundry-test that referenced this pull request Sep 11, 2024
…uring deployment (foundry-rs#8625)

* add Mandala & Karura & Acala

* update alloy-chains

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants