-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove ethers #8826
Merged
Merged
feat: remove ethers #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
approved these changes
Sep 6, 2024
DaniPopes
force-pushed
the
dani/rm-ethers-final
branch
from
September 6, 2024 15:05
fa0e53f
to
88af4bb
Compare
13 tasks
zerosnacks
added
the
T-likely-breaking
Type: requires changes that can be breaking
label
Sep 24, 2024
DaniPopes
force-pushed
the
dani/rm-ethers-final
branch
from
October 7, 2024 14:12
88af4bb
to
11045a3
Compare
DaniPopes
force-pushed
the
dani/rm-ethers-final
branch
from
October 7, 2024 15:26
11045a3
to
adec18f
Compare
@DaniPopes is this good to review / send or are there other deps? thank you! |
It's good to go |
grandizzy
requested review from
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
November 26, 2024 12:45
grandizzy
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
grandizzy
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts commit d739704.
grandizzy
added a commit
that referenced
this pull request
Nov 26, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
Revert "feat: remove ethers (foundry-rs#8826)" This reverts commit d739704.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
L-ignore
Log: ignore PR in changelog
T-blocked
Type: blocked
T-likely-breaking
Type: requires changes that can be breaking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last usage of ethers in the bindings generator.
Reduces the number of dependencies by 30+.
To be merged for 1.0.