Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove ethers #8826

Merged
merged 2 commits into from
Nov 26, 2024
Merged

feat: remove ethers #8826

merged 2 commits into from
Nov 26, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 6, 2024

Removes the last usage of ethers in the bindings generator.

Reduces the number of dependencies by 30+.

To be merged for 1.0.

@DaniPopes DaniPopes added this to the v1.0.0 milestone Sep 6, 2024
@DaniPopes DaniPopes force-pushed the dani/rm-ethers-final branch from fa0e53f to 88af4bb Compare September 6, 2024 15:05
@zerosnacks zerosnacks added the T-blocked Type: blocked label Sep 6, 2024
@zerosnacks zerosnacks added the T-likely-breaking Type: requires changes that can be breaking label Sep 24, 2024
@DaniPopes DaniPopes force-pushed the dani/rm-ethers-final branch from 88af4bb to 11045a3 Compare October 7, 2024 14:12
@DaniPopes DaniPopes force-pushed the dani/rm-ethers-final branch from 11045a3 to adec18f Compare October 7, 2024 15:26
@grandizzy
Copy link
Collaborator

@DaniPopes is this good to review / send or are there other deps? thank you!

@DaniPopes
Copy link
Member Author

It's good to go

@grandizzy grandizzy marked this pull request as ready for review November 26, 2024 12:45
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@grandizzy grandizzy merged commit d739704 into master Nov 26, 2024
22 checks passed
@grandizzy grandizzy deleted the dani/rm-ethers-final branch November 26, 2024 13:04
grandizzy added a commit that referenced this pull request Nov 26, 2024
@grandizzy grandizzy restored the dani/rm-ethers-final branch November 26, 2024 14:23
grandizzy added a commit that referenced this pull request Nov 26, 2024
Revert "feat: remove ethers (#8826)"

This reverts commit d739704.
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
Revert "feat: remove ethers (foundry-rs#8826)"

This reverts commit d739704.
@grandizzy grandizzy added the L-ignore Log: ignore PR in changelog label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-ignore Log: ignore PR in changelog T-blocked Type: blocked T-likely-breaking Type: requires changes that can be breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants