chore: fire shutdown signal on anvil node handle drop #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
NodeHandle.fire_shutdown_signal
mattsse
approved these changes
Sep 24, 2024
DaniPopes
reviewed
Sep 24, 2024
ArkFunds
approved these changes
Sep 24, 2024
ArkFunds
approved these changes
Sep 24, 2024
DaniPopes
approved these changes
Sep 24, 2024
DaniPopes
requested changes
Sep 24, 2024
crates/anvil/src/lib.rs
Outdated
| /// | ||
| /// Called by long-running tests to make sure anvil instance is terminated. | ||
| #[track_caller] | ||
| pub fn fire_shutdown_signal(&mut self) { |
There was a problem hiding this comment.
Can this go into an impl Drop?
There was a problem hiding this comment.
yes, will do and make some tests
There was a problem hiding this comment.
hm, weird, I added in drop
+impl Drop for NodeHandle {
+ fn drop(&mut self) {
+ if let Some(signal) = self._signal.take() {
+ signal.fire().unwrap()
+ }
+ }
+}and then got again a failure like
failed to spawn node: Os { code: 98, kind: AddrInUse, message: "Address already in use" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
proof::test_account_proof
going to make some more tests to see if consistently happens
There was a problem hiding this comment.
added in 277d62c ptal
grandizzy
changed the title
NodeHandle.fire_shutdown_signal
ArkFunds
approved these changes
Sep 25, 2024
DaniPopes
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ref #8946 (review)
Solution