Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gas snapshots over arbitrary sections #8952

Merged
merged 56 commits into from
Oct 2, 2024
Merged

feat: gas snapshots over arbitrary sections #8952

merged 56 commits into from
Oct 2, 2024

Commits on Sep 24, 2024

  1. update internal naming

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4ef2ac6 View commit details
    Browse the repository at this point in the history

  2. further internals

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d90a09e View commit details
    Browse the repository at this point in the history

  3. deprecate cheats

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3d326d2 View commit details
    Browse the repository at this point in the history

  4. update Solidity tests and add dedicated test for testing deprecated c… 

    …heatcodes
    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    72b4e15 View commit details
    Browse the repository at this point in the history

  5. clarify gas snapshots

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7fed284 View commit details
    Browse the repository at this point in the history

  6. fix build

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d544326 View commit details
    Browse the repository at this point in the history

  7. final fixes

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8492c71 View commit details
    Browse the repository at this point in the history

  8. fix build

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a8f2ec5 View commit details
    Browse the repository at this point in the history

  9. fix repro 6355 rename

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2cca2c7 View commit details
    Browse the repository at this point in the history

  10. add gas snapshot setup from #8755

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9602aec View commit details
    Browse the repository at this point in the history

  11. fix build + clippy warnings

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1ced509 View commit details
    Browse the repository at this point in the history

  12. fix cheatcodes

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9348062 View commit details
    Browse the repository at this point in the history

  13. account for fixed CREATE / CALL gas cost

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    094a4bb View commit details
    Browse the repository at this point in the history

  14. remove import

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e9bd560 View commit details
    Browse the repository at this point in the history

  15. add stipend

    @zerosnacks
    zerosnacks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    836a400 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'master' into zerosnacks/add-gas-section-snapshot-cheatc… 

    …odes
    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    45ae718 View commit details
    Browse the repository at this point in the history

  2. recalculate after a - b setup

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1ebd5c3 View commit details
    Browse the repository at this point in the history

  3. clear call_stipend, update tests

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9f8ea19 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into zerosnacks/rename-state-snapshot

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fd97339 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'zerosnacks/rename-state-snapshot' into zerosnacks/add-g… 

    …as-section-snapshot-cheatcodes
    @zerosnacks
    zerosnacks authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4114b07 View commit details
    Browse the repository at this point in the history

  6. avoid double counting external calls

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    55d43f4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'zerosnacks/add-gas-section-snapshot-cheatcodes' of gith… 

    …ub.com:foundry-rs/foundry into zerosnacks/add-gas-section-snapshot-cheatcodes
    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eb3f0ae View commit details
    Browse the repository at this point in the history

  8. update cheatcodes, remove debug prints

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fe9822f View commit details
    Browse the repository at this point in the history

  9. enable assertions

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1b2439c View commit details
    Browse the repository at this point in the history

  10. clean up tests

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    aaee5d4 View commit details
    Browse the repository at this point in the history

  11. clean up test names

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1bb65a7 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into zerosnacks/add-gas-section-snapshot-cheatc… 

    …odes
    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    040a2bf View commit details
    Browse the repository at this point in the history

  13. remove snapshot directory on forge clean

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    162ab95 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into zerosnacks/rename-state-snapshot

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    50b8e54 View commit details
    Browse the repository at this point in the history

  15. do not remove all snapshots by default due to multiple test suites be… 

    …ing able to be ran concurrently or sequentially + optimize gas snapshots check - skip if none were captured
    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b78bd56 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'zerosnacks/rename-state-snapshot' into zerosnacks/add-g… 

    …as-section-snapshot-cheatcodes
    @zerosnacks
    zerosnacks authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dd7c457 View commit details
    Browse the repository at this point in the history

  17. handle edge case where we ask to compare but file does not exist, rem… 

    …ove snapshot directory at a top level before test suites are ran
    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7ae5dee View commit details
    Browse the repository at this point in the history

  18. Merge branch 'zerosnacks/add-gas-section-snapshot-cheatcodes' of gith… 

    …ub.com:foundry-rs/foundry into zerosnacks/add-gas-section-snapshot-cheatcodes
    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    54ea324 View commit details
    Browse the repository at this point in the history

  19. fix path issue when attempting removal

    @zerosnacks
    zerosnacks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    41800da View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Update crates/cheatcodes/src/evm.rs 

    Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
    @zerosnacks @klkvr
    zerosnacks and klkvr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6408bb1 View commit details
    Browse the repository at this point in the history

  2. Update crates/cheatcodes/src/inspector.rs 

    Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
    @zerosnacks @klkvr
    zerosnacks and klkvr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6c05e09 View commit details
    Browse the repository at this point in the history

  3. refactor, apply recommended changes for last_snapshot_group, last_sna… 

    …pshot_name
    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fcd43e4 View commit details
    Browse the repository at this point in the history

  4. remove gas snapshots from fuzz tests for now: this is largely due to … 

    …it conflicting with the FORGE_SNAPSHOT_CHECK where it is highly likely that with different fuzzed input the gas measurement differs as well. In the future it would be an idea to capture the average gas
    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c6b19b3 View commit details
    Browse the repository at this point in the history

  5. fix clippy

    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bca712f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into zerosnacks/rename-state-snapshot-bu

    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d040ea7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'zerosnacks/rename-state-snapshot-bu' into zerosnacks/ad… 

    …d-gas-section-snapshot-cheatcodes
    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6e0d85f View commit details
    Browse the repository at this point in the history

  8. avoid setting to 0 unnecessarily

    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    23fdf66 View commit details
    Browse the repository at this point in the history

  9. use if let Some

    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    86060d3 View commit details
    Browse the repository at this point in the history

  10. improve comments, clarify use of last_gas_used != 0

    @zerosnacks
    zerosnacks committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    92384b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. merge in master

    @zerosnacks
    zerosnacks committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b1e2567 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'master' into zerosnacks/add-gas-section-snapshot-cheatc… 

    …odes
    @zerosnacks
    zerosnacks committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    23d4410 View commit details
    Browse the repository at this point in the history

  2. fix merge conflict issue

    @zerosnacks
    zerosnacks committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f789e3d View commit details
    Browse the repository at this point in the history

  3. fix arg ordering to address group naming regression

    @zerosnacks
    zerosnacks committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8f62030 View commit details
    Browse the repository at this point in the history

  4. fix merge conflicts

    @zerosnacks
    zerosnacks committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    731cbe3 View commit details
    Browse the repository at this point in the history

  5. fix import

    @zerosnacks
    zerosnacks committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d3d1229 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. move snapshot name derivation to helper

    @zerosnacks
    zerosnacks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ab2cded View commit details
    Browse the repository at this point in the history

  2. only skip initial call w/ overhead, no special handling for call frames

    @zerosnacks
    zerosnacks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d3310f2 View commit details
    Browse the repository at this point in the history

  3. add flare test

    @zerosnacks
    zerosnacks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    73b4f81 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. style nits + use helper method

    @zerosnacks
    zerosnacks committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b74ae33 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into zerosnacks/add-gas-section-snapshot-cheatc… 

    …odes
    @zerosnacks
    zerosnacks committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0511d24 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into zerosnacks/add-gas-section-snapshot-cheatc… 

    …odes
    @zerosnacks
    zerosnacks authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e7c9bf9 View commit details
    Browse the repository at this point in the history