fix(cheatcodes): convert fixed bytes to bytes in vm.rpc tuple result #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
DaniPopes
reviewed
Oct 15, 2024
crates/cheatcodes/src/evm/fork.rs
Outdated
| // Convert fixed bytes to bytes in tuple to prevent encoding issues. | ||
| // See: <https://github.com/foundry-rs/foundry/issues/7858> | ||
| if let DynSolValue::FixedBytes(bytes, size) = *val { | ||
| *val = DynSolValue::Bytes(bytes.as_slice()[..size].to_vec()); |
There was a problem hiding this comment.
pls just extract the function and make it recursive
There was a problem hiding this comment.
changed in f38f578, please check
DaniPopes
approved these changes
Oct 16, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…oundry-rs#9117) * fix(cheatcodes): convert fixed bytes to bytes in vm.rpc tuple result * Changes after review: recursive convert_to_bytes fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7858
Solution