fix(cheatcodes): improve fork cheatcodes messages #9141
Conversation
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
crates/cheatcodes/src/evm/fork.rs
Outdated
| .ecx | ||
| .db | ||
| .create_select_fork(fork, &mut ccx.ecx.env, &mut ccx.ecx.journaled_state) | ||
| .map_err(|err| fmt_err!("{err:?}"))?; |
There was a problem hiding this comment.
If these are for eyre errors then i would revert these changes and update the implementation of From<eyre::Error>
foundry/crates/cheatcodes/src/error.rs
Line 296 in 8bdcbfa
There was a problem hiding this comment.
Makes sense, this would be also fixing same issue for non vm errors like here #8908 (comment) if I get this right?
There was a problem hiding this comment.
@DaniPopes pls check c0ea850 displaying as
|
I'm not a fan of multi-line errors because it skews formatting for the whole test report, it would be better if it was flattened into one line |
Agree, multi line looks good for cli reports but not for tests. |
|
You can get an iterator over the error messages with |
fix(cheatcodes): chain report source errors
Motivation
Closes #8908
follow up on #8936 (review) not sure what's the best solution here but I hit this while doing some tests, the issue is with wrapped errors that are not displaying entirely when failed from cheatcodes and propagated to test result, #8936 could be a better solution as will handle all other cases if any...
with this approach:
with fix(
evm): improve err messaging #8936 approachcurrent
@yash-atreya @mattsse @klkvr
Solution