fix(anvil): set auto-unlock an alias of auto-impersonate #9256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
grandizzy
approved these changes
Nov 4, 2024
leovct
pushed a commit
to leovct/foundry
that referenced
this pull request
Nov 6, 2024
…9256) * fix(anvil): alias --auto-unlock of auto-impersonate Signed-off-by: jsvisa <delweng@gmail.com> * feat(anvil): add more clear help messge for auto-impersonate Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…9256) * fix(anvil): alias --auto-unlock of auto-impersonate Signed-off-by: jsvisa <delweng@gmail.com> * feat(anvil): add more clear help messge for auto-impersonate Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The alias of
auto-impersonateis no diff of the original value:$ anvil --help --auto-impersonate Enable autoImpersonate on startup [aliases: auto-impersonate]And as
--unlockedhas different meanings incast(ref #5335 (comment))So let's add
auto-unlockas an alias of this argument.Solution