Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge test): record only test fns in test failures #9286

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 8, 2024

Motivation

Closes #9285

  • when persisting test failures there's no check if failure is a test kind, hence setUp is also recorded

Solution

  • check if function is test when recording failure to rerun. if there are tests failing due to setup failure then they'll be recorded and replayed, if they don't depend on setup then won't fail and won't be replayed

@grandizzy grandizzy enabled auto-merge (squash) November 8, 2024 06:38
@grandizzy grandizzy merged commit f3376a6 into foundry-rs:master Nov 8, 2024
21 checks passed
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forge test --rerun should re-run entire test file where setUp() failed
2 participants