Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge create): install missing deps if any #9401

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(forge create): install missing deps if any #9401

merged 1 commit into from
Nov 25, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #4361

  • install missing deps when forge create, if any

Solution

@grandizzy grandizzy marked this pull request as ready for review November 25, 2024 09:38
@grandizzy grandizzy merged commit 66228e4 into foundry-rs:master Nov 25, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-4361 branch November 25, 2024 11:22
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy @rplusq
fix(forge create): install missing deps if any (foundry-rs#9401)
69ed230
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(forge): forge create should install dependencies
2 participants
@grandizzy @zerosnacks