feat: rewrite inline config using figment #9414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Nov 27, 2024
| invariant: config.invariant.clone(), | ||
| ..Default::default() | ||
| }) | ||
| .with_test_options(TestOptions::new(output, config.clone())?) |
There was a problem hiding this comment.
This wasn't parsing inline config, so it never worked for coverage
This was referenced Nov 27, 2024
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
DaniPopes
commented
Nov 28, 2024
| @@ -48,8 +48,9 @@ async fn test_invariant_with_alias() { | |||
|
|
|||
| #[tokio::test(flavor = "multi_thread")] | |||
| async fn test_invariant_filters() { | |||
| let mut runner = TEST_DATA_DEFAULT.runner(); | |||
| runner.test_options.invariant.runs = 10; | |||
| let mut runner = TEST_DATA_DEFAULT.runner_with(|config| { | |||
There was a problem hiding this comment.
These are changed because test_options is not mutable after construction
| self.config().project().expect("Failed to build project") | ||
| } | ||
|
|
||
| pub fn test_opts(&self, output: &ProjectCompileOutput) -> TestOptions { |
There was a problem hiding this comment.
These are moved to fn config since test options uses Config now
mattsse
approved these changes
Nov 28, 2024
| /// Contains per-test specific "invariant" configurations. | ||
| pub inline_invariant: InlineConfig<InvariantConfig>, | ||
| /// The base configuration. | ||
| pub config: Arc<Config>, |
grandizzy
reviewed
Nov 28, 2024
crates/forge/tests/it/fuzz.rs
Outdated
| @@ -145,6 +147,8 @@ async fn test_persist_fuzz_failure() { | |||
| assert_eq!(initial_calldata, new_calldata, "run {i}"); | |||
| } | |||
|
|
|||
| // TODO | |||
There was a problem hiding this comment.
will this be a followup PR or just a leftover?
zerosnacks
approved these changes
Nov 28, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* feat: rewrite inline config using figment * wip * wip * fix: use same GasLimit type * wip * fixes * tests * test fixes * fmt * test update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the current manual inline config value parser by using the existing
figmentinfrastructure used for parsing the mainConfigstruct.Inline config is now just some maps that hold figment values, and that returns a
figment::Providerwhen queried with a (contract, function) pair.Issues like #5371 are NOT fixed because this is not even implemented for the main foundry.toml parsing. Invalid keys are accepted even in foundry.toml. Once it's fixed for foundry.toml, it will easily be applied to inline config as well.
This also fixes inline config for coverage, which was not getting parsed before.