Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(coverage): cache computed bytecode hash in CoverageCollector #9457

Merged
merged 2 commits into from
Dec 2, 2024
Merged

perf(coverage): cache computed bytecode hash in CoverageCollector #9457

merged 2 commits into from
Dec 2, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 2, 2024 •
edited
Loading

I don't remember why this is not computed/cached in revm, but we can do it ourselves

Few more secs saved in solmate on top of #9456

@DaniPopes DaniPopes enabled auto-merge (squash) December 2, 2024 19:45
@DaniPopes DaniPopes merged commit d35fee6 into master Dec 2, 2024
21 checks passed
@DaniPopes DaniPopes deleted the dani/coverage-perf-inspector branch December 2, 2024 20:45
@grandizzy grandizzy added the T-perf Type: performance label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
T-perf Type: performance
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @mattsse @grandizzy