feat(cheatcodes): count assertion for expectRevert
#9484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
changed the title
cheatcodes): count assertion for expectRevert
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
1 task
zerosnacks
approved these changes
Dec 5, 2024
grandizzy
approved these changes
Dec 5, 2024
| ) { | ||
| if let Ok(decoded) = Vec::<u8>::abi_decode(&actual_revert[4..], false) { | ||
| actual_revert = decoded; | ||
| // Reverter check |
There was a problem hiding this comment.
this makes sense, cannot think of a cleaner way to structure code as we need to check both reverter and revert reason
yash-atreya
added a commit
to foundry-rs/forge-std
that referenced
this pull request
Dec 6, 2024
Ref: foundry-rs/foundry#9484 ```solidity /// Expects `count` number of reverts from the upcoming calls with any revert data or reverter. function expectRevert(uint64 count) external; /// Expects `count` number of reverts from the upcoming calls that match the revert data. function expectRevert(bytes4 revertData, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls that exactly match the revert data. function expectRevert(bytes calldata revertData, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls from the reverter address. function expectRevert(address reverter, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls from the reverter address that match the revert data. function expectRevert(bytes4 revertData, address reverter, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls from the reverter address that exactly match the revert data. function expectRevert(bytes calldata revertData, address reverter, uint64 count) external; ```
thomas-lamb-tech
pushed a commit
to thomas-lamb-tech/std_forge
that referenced
this pull request
Dec 26, 2024
Ref: foundry-rs/foundry#9484 ```solidity /// Expects `count` number of reverts from the upcoming calls with any revert data or reverter. function expectRevert(uint64 count) external; /// Expects `count` number of reverts from the upcoming calls that match the revert data. function expectRevert(bytes4 revertData, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls that exactly match the revert data. function expectRevert(bytes calldata revertData, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls from the reverter address. function expectRevert(address reverter, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls from the reverter address that match the revert data. function expectRevert(bytes4 revertData, address reverter, uint64 count) external; /// Expects `count` number of reverts from the upcoming calls from the reverter address that exactly match the revert data. function expectRevert(bytes calldata revertData, address reverter, uint64 count) external; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #509
Solution
Implement
expectRevertoverloads with thecountarg. Negative assertions can be made by settingcountto0