Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract podwhisperer PR feature and add AI summarisation #2

Merged
merged 18 commits into from
Nov 2, 2023

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Oct 27, 2023

This project/PR extracts the previous pull request functionality from Podwhisperer, leaving Podwhisperer to focus on transcript generation. This new project ("episoder") focuses on creating the Pull Request for the podcast website with the JSON transcript but also adds some GenAI-created episode summary and chapter summary information.

@eoinsha eoinsha requested a review from lmammino October 27, 2023 13:41
Copy link
Contributor

@lmammino lmammino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool stuff! Added some minor comments here and there!

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
functions/pull-request/pr-description.ts Outdated Show resolved Hide resolved
import { logger, metrics, middify, tracer } from '../../lib/lambda-common'
import { getS3JSON } from '../../lib/utils'
import { createSummary } from '../../lib/summarisation'
import { Summary, Transcript } from '../../lib/types'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random comment... I am surprised that TS does not force you to include extensions (.ts or .js)... 🤷🏽 it must be one of the million flags you can specify in the tsconfig.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what dictates the behaviour here. I don't think there's anything specific in the tsconfig.json. From here, .ts seems to be inferred by default but I also have other projects where I had to include the extension in the import 🤷‍♀️

lib/envs.ts Show resolved Hide resolved
lib/prompt-template.ts Outdated Show resolved Hide resolved
tests/functions/summary/app.test.ts Show resolved Hide resolved
eoinsha and others added 2 commits November 2, 2023 21:51
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
- use latest GHA action versions without warnings
- add Luciano's PR feedback

Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
@eoinsha eoinsha merged commit 6d19890 into main Nov 2, 2023
2 checks passed
@eoinsha eoinsha deleted the pr-with-summary branch November 2, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants