-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract podwhisperer PR feature and add AI summarisation #2
Conversation
8d68def
to
299eb87
Compare
299eb87
to
182f1e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool stuff! Added some minor comments here and there!
import { logger, metrics, middify, tracer } from '../../lib/lambda-common' | ||
import { getS3JSON } from '../../lib/utils' | ||
import { createSummary } from '../../lib/summarisation' | ||
import { Summary, Transcript } from '../../lib/types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random comment... I am surprised that TS does not force you to include extensions (.ts
or .js
)... 🤷🏽 it must be one of the million flags you can specify in the tsconfig.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what dictates the behaviour here. I don't think there's anything specific in the tsconfig.json
. From here, .ts
seems to be inferred by default but I also have other projects where I had to include the extension in the import 🤷♀️
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
- use latest GHA action versions without warnings - add Luciano's PR feedback Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
7c8e0e1
to
fdbe860
Compare
This project/PR extracts the previous pull request functionality from Podwhisperer, leaving Podwhisperer to focus on transcript generation. This new project ("episoder") focuses on creating the Pull Request for the podcast website with the JSON transcript but also adds some GenAI-created episode summary and chapter summary information.