-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
@evanmwillhite The steps to review work as expected, but none of them included using the new files in an Emulsify-based theme... So, how can I verify that the new PL component will get used? |
@@ -1,16 +1,16 @@ | |||
# Breakpoints - change based on site need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evanmwillhite Why did you reverse the order of these? I thought they had to be largest to smallest in order for things to work correctly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my experience was the opposite. It didn't work until I did this. Can you confirm in your testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Core updated, and automatically inverts the breakpoints you list here. Thanks for the info!
@@ -1,16 +1,16 @@ | |||
# Breakpoints - change based on site need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Core updated, and automatically inverts the breakpoints you list here. Thanks for the info!
This PR adds the ability to use responsive images in a component-driven manner without affecting previous projects.
Usage is noted in
themes/emulsify/components/_patterns/01-atoms/04-images/00-image/responsive-image.md
To Test:
Select a single image style.
and select an image style. Save this form to save the new style.