Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

SVG sprite method change #206

Merged
merged 2 commits into from
May 8, 2018
Merged

SVG sprite method change #206

merged 2 commits into from
May 8, 2018

Conversation

evanmwillhite
Copy link
Contributor

@evanmwillhite evanmwillhite commented Feb 27, 2018

Note: This and the matching PR for Emulsify Gulp must be merged/released simultaneously

Switches SVG sprite method to use symbol (from background CSS).

To Test:

  • Clone a fresh copy of Emulsify and set your Emulsify Gulp devDependency in package.json to fourkitchens/emulsify-gulp#SVG-method-switch
  • Install as usual and yarn start
  • Verify the Icons section looks OK as well as any components using an icon
  • Verify any leftover code has been removed from the background CSS approach
  • Follow the instructions in components/_patterns/01-atoms/04-images/icons/icons.md to add new icons and test a variety of ways of using them.
  • Verify all works accordingly.

@evanmwillhite evanmwillhite merged commit 14fb9f1 into develop May 8, 2018
@evanmwillhite evanmwillhite deleted the SVG-method-switch branch May 8, 2018 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants