Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

237: removed JS class on non-JS implementation #246

Merged
merged 1 commit into from
Jun 11, 2018
Merged

237: removed JS class on non-JS implementation #246

merged 1 commit into from
Jun 11, 2018

Conversation

evanmwillhite
Copy link
Contributor

Fixes #237

  • Removes tab class for non-JS (Drupal) implementations like local tasks.
  • Adds styling to both classes so they look the same

@evanmwillhite evanmwillhite mentioned this pull request Jun 4, 2018
Closed
left23
left23 approved these changes Jun 11, 2018
View reviewed changes
Copy link

@left23 left23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it fixes the issue as described in #237

ModulesUnraveled
ModulesUnraveled approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@ModulesUnraveled ModulesUnraveled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward. I didn't functionally review, but the code makes sense

@evanmwillhite evanmwillhite merged commit b25b95a into develop Jun 11, 2018
@evanmwillhite evanmwillhite deleted the 237-tabs-fix branch June 11, 2018 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@left23 left23 left23 approved these changes

@ModulesUnraveled ModulesUnraveled ModulesUnraveled approved these changes

Assignees
No one assigned
Labels
Priority: Low Status: Review Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanmwillhite @ModulesUnraveled @left23