Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix birthtime if not present #10

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Fix birthtime if not present #10

merged 2 commits into from
Nov 14, 2022

Conversation

Schamper
Copy link
Member

(DIS-1659)

@Schamper Schamper self-assigned this Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #10 (d223a2d) into main (abd3482) will decrease coverage by 0.95%.
The diff coverage is 0.00%.

❗ Current head d223a2d differs from pull request most recent head a7cbfc3. Consider uploading reports for the commit a7cbfc3 to get more accurate results

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   66.42%   65.46%   -0.96%     
==========================================
  Files           4        4              
  Lines         274      278       +4     
==========================================
  Hits          182      182              
- Misses         92       96       +4     
Flag Coverage Δ
unittests 65.46% <0.00%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/ffs/ffs.py 63.49% <0.00%> (-0.99%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yunzheng
yunzheng previously approved these changes Nov 14, 2022
Copy link
Member

@yunzheng yunzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise LGTM

dissect/ffs/ffs.py Outdated Show resolved Hide resolved
Copy link
Member

@yunzheng yunzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schamper Schamper merged commit 96a1f3f into main Nov 14, 2022
@Schamper Schamper deleted the dis-1659_fix-ffs1-btime branch November 14, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants