Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal symlinks #11

Merged
merged 11 commits into from
Nov 21, 2022
Merged

Conversation

cecinestpasunepipe
Copy link
Contributor

  • Implement missing symlink functionality.
  • Fix internal symlinks, add tests.
  • Workaround for nul-byte issue.

(DIS-916)

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #11 (956a3fe) into main (96a1f3f) will increase coverage by 5.71%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   65.46%   71.18%   +5.71%     
==========================================
  Files           4        4              
  Lines         278      288      +10     
==========================================
+ Hits          182      205      +23     
+ Misses         96       83      -13     
Flag Coverage Δ
unittests 71.18% <95.83%> (+5.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/ffs/ffs.py 69.59% <95.83%> (+6.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cecinestpasunepipe cecinestpasunepipe changed the title Fix internal symlinks (DIS-916) Fix internal symlinks Nov 17, 2022
@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-916_fix_internal_symlinks branch 2 times, most recently from 4c632e8 to 1e229c9 Compare November 17, 2022 14:44
pyrco
pyrco previously approved these changes Nov 17, 2022
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
dissect/ffs/ffs.py Outdated Show resolved Hide resolved
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@cecinestpasunepipe cecinestpasunepipe merged commit 2701584 into main Nov 21, 2022
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-916_fix_internal_symlinks branch November 21, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants