Skip to content

Commit

Permalink
#70 #38 Shared library (DLL) must also make dependent system libs pub…
Browse files Browse the repository at this point in the history
…lic for Windows build.
  • Loading branch information
fpagliughi committed Jan 30, 2023
1 parent af4104f commit 3b19748
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ if(${SOCKPP_BUILD_SHARED})
${SOCKPP_GENERATED_DIR}/include
)

target_link_libraries(${SOCKPP_SHARED_LIBRARY} PRIVATE ${LIBS_SYSTEM})
target_link_libraries(${SOCKPP_SHARED_LIBRARY} PUBLIC ${LIBS_SYSTEM})

set_target_properties(${SOCKPP_SHARED_LIBRARY} PROPERTIES
VERSION ${PROJECT_VERSION}
SOVERSION ${PROJECT_VERSION_MAJOR}
Expand All @@ -137,7 +137,7 @@ if(${SOCKPP_BUILD_STATIC})
)

target_link_libraries(${SOCKPP_STATIC_LIBRARY} PUBLIC ${LIBS_SYSTEM})

set_target_properties(${SOCKPP_STATIC_LIBRARY} PROPERTIES
CXX_EXTENSIONS OFF
)
Expand All @@ -151,12 +151,12 @@ if(${SOCKPP_BUILD_STATIC})
OUTPUT_NAME ${SOCKPP_SHARED_LIBRARY}
)
endif()

list(APPEND TARGET_FILES ${SOCKPP_STATIC_LIBRARY})
endif()

# --- Install Targets ---

include(GNUInstallDirs)

install(TARGETS ${TARGET_FILES}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ If you're using this library, tweet at me or send me a message, and let me know

## New in v0.8.1

This release attempts to fix some of the outstanding build issues on Windows with MSVC and resolv some old issues and PR commits.
This release attempts to fix some of the outstanding build issues on Windows with MSVC and resolve some old issues and PR commits.

- Cherry picked most of the non-TLS commits in PR [#17](https://github.com/fpagliughi/sockpp/pull/17)
- Connector timeouts
Expand Down

0 comments on commit 3b19748

Please sign in to comment.