-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend installing stack instead of MinGHC #75 #87
Conversation
@@ -1,10 +1,31 @@ | |||
# stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right at the head of MinGHC seems a bit surprising. Perhaps this could be a subsection instead?
I'm certainly a fan of this in principle. |
My only concern is that I often want GHC 7.4, 7.6, 7.8 and 7.10 all installed. In contrast, with Stack, I tend to get various lts versions, and that doesn't really give me GHC versions. Maybe that's really a weakness in Stack, and there should be ghc-7.10.N as a tag, which is the most recent lts of GHC 7.10? If there was a good story there I'd be in favour. |
Also the minghc-7.8.bat script is invaluable, I don't know how to do that with stack. |
I think I can answer both of those:
FWIW, I get by when developing on Windows just fine by calling @3noch I just pushed a commit, though I'm not thrilled with how it makes the README look. I'm OK with this or other tweaks. |
I was thinking something akin to MinGHCStop: You likely want to use stack instead......... |
@snoyberg I made some edits. Feel free to change. Like I said, I'm for this direction. |
@@ -1,10 +1,33 @@ | |||
# Minimum GHC Installer [![Build Status](https://img.shields.io/travis/fpco/minghc.svg?style=flat)](https://travis-ci.org/fpco/minghc) | |||
|
|||
## Wait, are you sure you don't want `stack`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I codified
stack
to minimize ambiguity for someone very new to the Haskell ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we go ahead with this?
On Tue, Sep 8, 2015, 11:23 PM Elliot Cameron notifications@github.com
wrote:
In README.md #87 (comment)
:@@ -1,10 +1,33 @@
Minimum GHC Installer
+## Wait, are you sure you don't want
stack
?I codified stack to minimize ambiguity for someone very new to the
Haskell ecosystem.—
Reply to this email directly or view it on GitHub
https://github.com/fpco/minghc/pull/87/files#r38974983.
Any thoughts @ndmitchell? The README is probably a nice litmus test for this change since I'm guessing most newcomers find MinGHC via haskell.org. |
## MinGHC | ||
|
||
MinGHC is still a supported and active project, and makes sense for people | ||
looking for network-free installers for a Haskell toolchain. For more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or specific GHC versions including older versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you tell stack
to use specific GHC versions too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only back to 7.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we're not uploading anything prior to that anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 7.2.2 on the web page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make an explicit exception in this list saying "if you need an older version of GHC, use MinGHC."
I've made one tweak. I also suggest we also supply a bullet point list of how to use Stack like you would minghc. Something like download binary, add to path, type stack install --ghc, run stack ghc. At the moment it's not immediately obvious how stack can do the job of minghc. |
Good call. I think it'd be better to have stack host some sort of install story for Windows and just link to that. |
That would be even better. |
To be clear: we're talking about stack providing an NSIS-based installer for Windows in addition to the raw executable, correct? I can definitely see value in that, and it would need to just:
I'm sure there are issues we'd need to get into though about code signing, user vs global install, but something along those lines seems reasonable. |
Actually I was just talking about some sort of "How to" guide. But I have also thought of doing a tiny installer for stack in the past. Perhaps now's the time for that? |
The installation procedure as it is today is covered on the downloads page: https://github.com/commercialhaskell/stack/wiki/Downloads#windows |
And there's already an issue about an nsis installer at: commercialhaskell/stack#613 |
Cool! |
I was merely talking about instructions, not an installer, on which I'm ambivalent (I prefer zip files to installers). The download says how to get stack on your PATH. With MinGHC we put a working ghc on your path, which is very useful for people experimenting and not using cabal (which is pretty much all beginners to start with). What's missing is "run stack ghc or stack ghci to invoke ghc", and then stack gives the MinGHC experience. |
I think this answers @ndmitchell's concerns. @3noch maybe you have ideas on better wording?
OK, merging. We can improve the language over time, and the installer issue is already tracked upstream with stack. |
Recommend installing stack instead of MinGHC #75
Pinging @ndmitchell and @3noch. I'm putting this up for a PR because I really do want this to be a discussion, not just a decision on my part. It seems to me like this is a fair assessment of what we discussed on #75, but let's make sure this correctly reflects what we all believe.