Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CI to run on "Ready for review" #100

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ManiMozaffar
Copy link
Contributor

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes
I find this useful, because if PR is WIP, then we'll mark it as draft, I don't want the CI tests to be triggered when it's on draft, which doesn't, but then when I press the button "ready for review" the ci test should run.
Right now, dev should make "ANOTHER COMMIT" to trigger the ci, when a pr is moved from draft to ready to be reviewed

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41d853b) 0.00% compared to head (be55de6) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #100   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          5       5           
=====================================
  Misses         5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpgmaas fpgmaas merged commit 73e88fc into fpgmaas:main Dec 14, 2023
8 checks passed
@fpgmaas
Copy link
Owner

fpgmaas commented Dec 14, 2023

Sorry that this took way too long to merge! Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants