Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): only load local modules once #242

Merged

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Local modules retrieval is currently done multiple times, as it's done in a for loop. This PR makes sure that it's only done once, greatly reducing the run time on big projects.

@codecov-commenter
Copy link

Codecov Report

Merging #242 (8b5ad30) into main (8a71695) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #242   +/-   ##
=====================================
  Coverage   95.7%   95.7%           
=====================================
  Files         32      32           
  Lines        914     915    +1     
  Branches     203     203           
=====================================
+ Hits         875     876    +1     
  Misses        26      26           
  Partials      13      13           
Impacted Files Coverage Δ
deptry/core.py 97.6% <100.0%> (+<0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner merged commit a2866fe into fpgmaas:main Dec 26, 2022
@mkniewallner mkniewallner deleted the perf/load-local-modules-once branch December 26, 2022 13:01
@fpgmaas fpgmaas mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants