Skip to content

Commit

Permalink
chore(deps-dev): bump undici from 6.11.1 to 6.13.0 (elastic#3975)
Browse files Browse the repository at this point in the history
test(undici): reduce testing of undici@6 on older Node.js v18 versions because of undici breakage

Starting with undici@6.13.0, it breaks on Node.js 18.13.0 and earlier.
Undici somewhat officially only supports the latest minor version of supported
Node.js majors, so we'll bump our testing to only more recent Node.js v18 versions.

Refs: nodejs/undici#3123
Co-authored-by: Trent Mick <trent.mick@elastic.co>
  • Loading branch information
2 people authored and fpm-peter committed Aug 20, 2024
1 parent 203fd3c commit fdeba1f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .tav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ undici:
- versions:
mode: max-7
include: '>=6.0.0 <7'
node: '>=18'
node: '>=18.17.0'
commands: node test/instrumentation/modules/undici/undici.test.js
- versions:
mode: max-7
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion test/_is_undici_incompat.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ function isUndiciIncompat() {
const undiciVer = require('undici/package.json').version;
const msg = `undici@${undiciVer} is incompatible with node@${nodeVer}`;

if (satisfies(undiciVer, '>=6.0.0') && satisfies(nodeVer, '<18.0.0')) {
if (satisfies(undiciVer, '>=6.13.0') && satisfies(nodeVer, '<18.17.0')) {
// See discussion at https://github.com/nodejs/undici/issues/3123
return msg;
} else if (satisfies(undiciVer, '>=6.0.0') && satisfies(nodeVer, '<18.0.0')) {
return msg;
} else if (
satisfies(undiciVer, '>=5.28.0') &&
Expand Down

0 comments on commit fdeba1f

Please sign in to comment.