catch all Image Exceptions #92

fr0tt · Oct 17, 2023 · 4667d21 · 4667d21
1 parent 8c71e5e
commit 4667d21
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/Services/PostService.php b/app/Services/PostService.php
@@ -6,8 +6,8 @@
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Str;
+use Intervention\Image\Exception\ImageException;
 use Intervention\Image\Facades\Image;
-use Intervention\Image\Exception\RuntimeException;
 use Illuminate\Support\Facades\Storage;
 use HeadlessChromium\BrowserFactory;
 
@@ -243,7 +243,7 @@ public function getInfo(string $url, $act_as_bot = false)
                 $color = $meta->getAttribute('content');
             } else if ($meta->getAttribute('property') === 'og:image') {
                 if ($meta->getAttribute('content') != '') {
-                    $image_path = $meta->getAttribute('content'); 
+                    $image_path = $meta->getAttribute('content');
                     if (Str::startsWith($image_path, parse_url($image_path)['path'])) {
                         $image_path = $this->composeImagePath($image_path, $base_url, $url);
                     }
@@ -321,10 +321,10 @@ public function saveImage($image_path, Post $post)
 
         try {
             $image = Image::make($image_path);
-        } catch (RuntimeException $e) {
+        } catch (ImageException $e) {
             Log::debug('Image could not be created');
         }
-        if (!$image) {
+        if (!isset($image)) {
             return;
         }