Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #46

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Improve docs #46

merged 2 commits into from
Oct 23, 2024

Conversation

visini
Copy link
Contributor

@visini visini commented Oct 23, 2024

Thank you for this exciting project.

I noticed two tiny improvements while going over the Readme and installing Litestream in my application.

Comment on lines 270 to 274
```ruby
authenticate :user, -> (user) { user.admin? } do
mount LitestreamRails::Engine, at: "/litestream"
mount Litestream::Engine, at: "/litestream"
end
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or remove this entirely? This exact example is already given above, in the beginning of the Dashboard section...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it for now.

Copy link
Owner

@fractaledmind fractaledmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@fractaledmind fractaledmind merged commit c372c7c into fractaledmind:main Oct 23, 2024
10 checks passed
@visini visini deleted the improve-docs branch October 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants