Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{ git.tag }} will not render tag 3.0.0-beta5 #143

Closed
xrow opened this issue Jul 14, 2022 · 4 comments · Fixed by #183
Closed

{{ git.tag }} will not render tag 3.0.0-beta5 #143

xrow opened this issue Jul 14, 2022 · 4 comments · Fixed by #183
Labels
fixed A fix has been submitted info required Further information is requested stale No news, closing

Comments

@xrow
Copy link

xrow commented Jul 14, 2022

{{ git.tag }} will display 3.0.0 if the last tag is 3.0.0-beta5.

I think there are many ways to fix this. Here is one idea.

[root@localhost helm-ezplatform]# git describe --tags
3.0.0-beta5-12-gfb09168
[root@localhost helm-ezplatform]# git tag --list | sort -V | tail -n1
3.0.0-beta5
@fralau
Copy link
Owner

fralau commented Jul 14, 2022

It is true that the code is cutting the last part of git describe --tags, i.e. anyting before -.

The question is whether that behavior would be requested by all users (necessary, useful)?

Please argue in favor or against removing that cut.

@xrow
Copy link
Author

xrow commented Jul 14, 2022

Sorry it is just a a bug on how the string is parsed. There should be no pro con needed. :-)

I just wanted to report it.

@fralau
Copy link
Owner

fralau commented Jul 14, 2022

That cut looks arbitrary to me; that was my own idea, but I don't see any compelling reason for keeping it.

fralau pushed a commit that referenced this issue Jul 22, 2022
  - Also: fix useless argument page in MacrosPlugin.render()
@fralau
Copy link
Owner

fralau commented Jul 22, 2022

Let me know if that fixes it for you?

@fralau fralau added fixed A fix has been submitted info required Further information is requested labels Jul 22, 2022
@fralau fralau added the stale No news, closing label Oct 28, 2022
@fralau fralau closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed A fix has been submitted info required Further information is requested stale No news, closing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants